Fix 64-bit time_t on 32 bit architectures #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest gcc on Debian unstable i386 starts to fail with > tests/test-umockdev-vala.vala:714:19: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > xfer[0].tx_buf = (uint64) tx_buf; It's right -- this *is* an evil and wrong cast, but unfortunately Linux defines the struct precisely as that -- `u64`, on all platforms. As we can't selectively `#pragma` these away, disable the fatal warning globally.
Unsetting `_FILE_OFFSET_BITS` causes time_t to be treated as 32-bit instead of the 64-bit that we want with `-D_TIME_BITS=64`. Fixes #216 Co-Authored-By: Steve Langasek <[email protected]> Co-Authored-By: Martin Pitt <[email protected]>
The structure of struct input_event varies depending on whether 64-bit `time_t` is in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @vorlonofportland and @liuzixing for these! Taken from ubuntu delta, package can be re-synced after landing this and making a new release.
Fixes #216